[bitnami/jenkins] Stabilize Jenkins by adding a replicaCount #25108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Raphaela <[email protected]>
Signed-off-by: Raphaela <[email protected]>
Signed-off-by: Raphaela <[email protected]>
|
@chrira please check |
Signed-off-by: Raphaela <[email protected]>
Signed-off-by: Raphaela <[email protected]>
Signed-off-by: Raphaela <[email protected]>
|
This Pull Request has been automatically marked as "stale" because it has not had recent activity (for 15 days). It will be closed if no further activity occurs. Thank you for your contribution. |
chrira
suggested changes
Apr 26, 2024
javsalgar
changed the title
|
Hi! Thank you so much for the PR! Could you bump the chart version? |
|
Due to the lack of activity in the last 5 days since it was marked as "stale", we proceed to close this Pull Request. Do not hesitate to reopen it later if necessary. |
Signed-off-by: Raphaela <[email protected]>
Signed-off-by: Raphaela <[email protected]>
|
There are some failing actions: You need to bump the chart version to properly release a new Helm chart with those changes |
Signed-off-by: Raphaela Seeger <[email protected]>
chrira
approved these changes
May 16, 2024
carrodher
added
verify
Signed-off-by: David Gomez <[email protected]>
dgomezleon
approved these changes
May 20, 2024
fmulero
pushed a commit
to fmulero/charts
that referenced
this pull request
May 22, 2024
…#25108) * Add replicaCount to values Signed-off-by: Raphaela <[email protected]> * Add replicCount to deployment.yaml Signed-off-by: Raphaela <[email protected]> * Add replicaCount to README.md Signed-off-by: Raphaela <[email protected]> * Update replicaCount to {} in values.yaml Signed-off-by: Raphaela <[email protected]> * Update deployment.yaml Signed-off-by: Raphaela <[email protected]> * Update values.yaml Signed-off-by: Raphaela <[email protected]> * Simplify ReplicaCount Signed-off-by: Raphaela <[email protected]> * Simplify replica solution Signed-off-by: Raphaela <[email protected]> * Update ReadMe and Bump version Signed-off-by: Raphaela Seeger <[email protected]> --------- Signed-off-by: Raphaela <[email protected]> Signed-off-by: Raphaela Seeger <[email protected]> Signed-off-by: David Gomez <[email protected]> Co-authored-by: Raphaela Seeger <[email protected]> Co-authored-by: David Gomez <[email protected]> Signed-off-by: Fran Mulero <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
Add replicaCount to declare replicaCout in Values
Benefits
By declaring the replicaCount, it removes the possibility to have the replicas scaled up or down my external applications (ArgoCD, ...)
Possible drawbacks
Applicable issues
Additional information
Checklist
Chart.yamlaccording to semver. This is not necessary when the changes only affect README.md files.README.mdusing readme-generator-for-helm